Fix handle stop partition request #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handle unexpected message for topic reader
Valeria1235
suggested changes
May 25, 2023
|
|
||
|
|
||
| class UnexpectedGrpcMessage(Error): | ||
| def __init__(self, message: str): |
| _buffer_size_bytes: int # use for init request, then for debug purposes only | ||
| _decode_executor: concurrent.futures.Executor | ||
| _decoders: Dict[int, typing.Callable[[bytes], bytes]] # dict[codec_code] func(encoded_bytes)->decoded_bytes | ||
| _logger: logging.Logger |
Contributor
There was a problem hiding this comment.
what is this internal logger for? I think this is strange and complicating.
| def set_logged(*args, **kwargs): | ||
| logged.set() | ||
|
|
||
| stream_reader._logger = mock.Mock() |
Contributor
There was a problem hiding this comment.
I think there are more beautiful and simple way to check log in pytest.
looks at https://docs.pytest.org/en/7.1.x/how-to/logging.html#caplog-fixture
Valeria1235
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Raise unimplemented exception for stop partition request
What is the new behavior?
Hanlde stop partition request
Close #297